Dispatch read one byte of the code, so a code with a non-zero high byte was handled as its low byte. Message::get_message_code now reads the whole little-endian uint32 and handlers register by u32. PeerInit and PierceFirewall, the only frames with a one-byte code, get their own accessor for the listener's first frame.
57 lines
1.6 KiB
Rust
57 lines
1.6 KiB
Rust
use crate::info;
|
|
use crate::{
|
|
message::{Message, MessageHandler},
|
|
peer::PeerMessage,
|
|
};
|
|
use std::sync::mpsc::Sender;
|
|
|
|
pub struct UploadDeniedHandler;
|
|
impl MessageHandler<PeerMessage> for UploadDeniedHandler {
|
|
fn get_code(&self) -> u32 {
|
|
50
|
|
}
|
|
fn handle(&self, message: &mut Message, sender: Sender<PeerMessage>) {
|
|
let filename = message.read_string();
|
|
let reason = message.read_string();
|
|
info!("Upload denied for {}: {}", filename, reason);
|
|
if reason == "Queued" {
|
|
return;
|
|
}
|
|
let _ = sender.send(PeerMessage::UploadFailed(String::new(), filename));
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
use crate::message::framed;
|
|
|
|
#[test]
|
|
fn a_queued_reason_is_not_a_failure() {
|
|
let (tx, rx) = std::sync::mpsc::channel();
|
|
let mut message = framed(|m| {
|
|
m.write_string("@@share\\gone.mp3").write_string("Queued");
|
|
});
|
|
|
|
UploadDeniedHandler.handle(&mut message, tx);
|
|
assert!(rx.try_recv().is_err());
|
|
}
|
|
|
|
#[test]
|
|
fn the_denied_filename_is_forwarded() {
|
|
let (tx, rx) = std::sync::mpsc::channel();
|
|
let mut message = framed(|m| {
|
|
m.write_string("@@share\\gone.mp3")
|
|
.write_string("File not shared.");
|
|
});
|
|
|
|
UploadDeniedHandler.handle(&mut message, tx);
|
|
match rx.try_recv() {
|
|
Ok(PeerMessage::UploadFailed(_, filename)) => {
|
|
assert_eq!(filename, "@@share\\gone.mp3");
|
|
}
|
|
other => panic!("unexpected: {other:?}"),
|
|
}
|
|
}
|
|
}
|