chore: tweak blocking peer connections

src/actor/peer_actor.rs

@@ -389,25 +389,9 @@ impl PeerActor {
 
         match socket_addr {
             Ok(addr) => {
-                if let Ok(stream) = TcpStream::connect(addr) {
+                // Use connect_timeout to prevent blocking the thread for too long
-                    if let Err(e) = stream.set_nonblocking(true) {
+                let timeout = Duration::from_secs(5);
-                        error!(
+                match TcpStream::connect_timeout(&addr, timeout) {
-                            "[peer:{}] Failed to set non-blocking: {}",
-                            username, e
-                        );
-                        self.disconnect_with_error(e);
-                        return false;
-                    }
-
-                    stream.set_nodelay(true).ok();
-
-                    self.stream = Some(stream);
-                    self.connection_state = ConnectionState::Connecting {
-                        since: Instant::now(),
-                    };
-                    true
-                } else {
-                    match TcpStream::connect(addr) {
                     Ok(stream) => {
                         if let Err(e) = stream.set_nonblocking(true) {
                             error!(
@@ -419,8 +403,7 @@ impl PeerActor {
                         }
                         stream.set_nodelay(true).ok();
                         self.stream = Some(stream);
-                            self.connection_state =
+                        self.connection_state = ConnectionState::Connecting {
-                                ConnectionState::Connecting {
                             since: Instant::now(),
                         };
                         true
@@ -431,7 +414,6 @@ impl PeerActor {
                     }
                 }
             }
-            }
             Err(e) => {
                 error!(
                     "[peer:{}] Invalid socket address {}:{} - {}",