fix!: make concurrent invocations work instead of silently seeing nothing (#22)

Running several one-shot commands at once returned "no results" for queries that
had plenty. Four defects, each of which made a dead session look like an empty
network:

- The peer listener bound its port inside a detached thread and panicked on
  EADDRINUSE, unwinding that thread alone. The process carried on with no
  listener, so no peer could deliver a search response. `Listen::bind` now takes
  the socket before login and falls back to an ephemeral port when the
  configured one is held.
- SetWaitPort advertised the configured port whether or not it was bound, so
  peers dialled a sibling process that discarded responses to tickets it never
  issued. The port the listener really holds is what gets advertised, mapped
  through UPnP, and reported by `whoami` and `serve`.
- A zero-byte read is EOF on a TCP socket, but MessageReader reported it as
  success, so a server that closed cleanly left the actor polling a dead socket.
  It is now an error, and Relogged (code 41) has a handler. The peer actor
  classifies that error: a control connection that was established and then
  closed is a clean disconnect, because peers drop idle sockets while the bytes
  move over their own connection, and reporting an error there fails every
  download queued with that peer including the one streaming. A connection that
  never established keeps the error path, which is what the server-brokered
  fallback reads to know a peer is unreachable.
- A session the server cut off - usually because another process logged in under
  the same name - exited 4, documented as "it worked and found nothing". Callers
  concluded the file was unavailable. Sessions now record why they ended and
  those verdicts become exit 7.

The server allows one session per account, so concurrency still needs a distinct
--username per run; SKILL.md documents that. The listener port needs no such
care any more.

Six e2e tests against soulfind cover it, each of which fails without the fix: a
taken listen port, a displaced session, three clients searching at once under
one configured port, the two CLI equivalents, and a peer that hangs up its
control connection while a transfer is still to come.

BREAKING CHANGE: `Listen::start` is replaced by `Listen::bind` and
`Listen::serve`, so the caller owns the socket and can read the port it actually
bound. `Client::listen_port` and `Client::session_loss` are new.

soulseek-rs-lib/src/client/connection.rs

@@ -53,14 +53,26 @@ impl Client {
         ctx.shares = shares;
         ctx.shared_directories.clone_from(&self.shared_directories);
 
-        let server_actor = ServerActor::new(
+        // Bind before logging in: the port we advertise has to be the port we
+        // hold, and a bind that fails outright is the caller's to see rather
+        // than a panic on a thread nobody is watching.
+        let listener = if self.enable_listen {
+            let listener = Listen::bind(self.listen_port)?;
+            self.bound_port = Some(listener.local_addr()?.port());
+            Some(listener)
+        } else {
+            None
+        };
+
+        let mut server_actor = ServerActor::new(
             self.address.clone(),
             sender,
-            self.listen_port,
+            self.bound_port.unwrap_or(self.listen_port),
             self.enable_listen,
             shared_folder_count,
             shared_file_count,
         );
+        server_actor.set_session_watch(self.session.clone());
 
         self.server_handle = Some(ctx.actor_system.spawn_with_handle(
             server_actor,
@@ -69,19 +81,13 @@ impl Client {
             },
         ));
 
-        if self.enable_listen {
-            let listen_port = self.listen_port;
+        if let Some(listener) = listener {
             let client_sender = listen_sender;
             let context = self.context.clone();
             let own_username = self.username.clone();
 
             thread::spawn(move || {
-                Listen::start(
-                    listen_port,
-                    client_sender,
-                    context,
-                    own_username,
-                );
+                Listen::serve(&listener, client_sender, context, own_username);
             });
         }
 

soulseek-rs-lib/src/client/mod.rs

@@ -5,7 +5,7 @@ use crate::actor::server_actor::{
 use crate::download_store::{DownloadStore, collect_failed_tokens};
 use crate::types::{
     ClientVersion, DownloadMetadata, DownloadStatus, RoomEvent, RoomInfo,
-    UserInfo, UserPresence, UserStats, UserStatus,
+    SessionLoss, SessionWatch, UserInfo, UserPresence, UserStats, UserStatus,
 };
 use crate::utils::logger;
 use crate::{
@@ -811,6 +811,9 @@ impl ClientContext {
 pub struct Client {
     enable_listen: bool,
     listen_port: u16,
+    /// The port the listener actually holds, known once [`Client::connect`]
+    /// has bound it.
+    bound_port: Option<u16>,
     address: PeerAddress,
     username: String,
     password: String,
@@ -818,6 +821,7 @@ pub struct Client {
     shared_directories: Vec<String>,
     server_handle: Option<ActorHandle<ServerMessage>>,
     context: Arc<RwLock<ClientContext>>,
+    session: SessionWatch,
 }
 
 impl Client {
@@ -834,6 +838,7 @@ impl Client {
         Self {
             enable_listen: settings.enable_listen,
             listen_port: settings.listen_port,
+            bound_port: None,
             address: settings.server_address,
             username: settings.username,
             password: settings.password,
@@ -841,6 +846,7 @@ impl Client {
             shared_directories: settings.shared_directories,
             context: Arc::new(RwLock::new(ClientContext::new())),
             server_handle: None,
+            session: SessionWatch::default(),
         }
     }
 
@@ -850,6 +856,23 @@ impl Client {
         &self.username
     }
 
+    /// The port peers can reach this client on, or `None` when it is not
+    /// listening (or has not connected yet). This is the port that was really
+    /// bound, which is not always the one that was configured.
+    #[must_use]
+    pub const fn listen_port(&self) -> Option<u16> {
+        self.bound_port
+    }
+
+    /// Why the server session ended, or `None` while it is alive.
+    ///
+    /// A lost session sees nothing on the network, so an empty result set from
+    /// one says nothing about what the network holds.
+    #[must_use]
+    pub fn session_loss(&self) -> Option<SessionLoss> {
+        self.session.loss()
+    }
+
     /// The directories whose files are currently shared with other peers.
     #[must_use]
     pub fn shared_directories(&self) -> Vec<String> {