style: crank clippy to pedantic+nursery and fix all lints

Enable the full clippy all + pedantic + nursery groups as workspace warnings,
with a small documented allow-list for the pedantic/nursery lints this project
intentionally does not follow (rustdoc-style requirements, deliberate numeric
casts in the protocol/UI layers, and a few noisy nursery lints). Also enable
the rust unused_lifetimes and unsafe_op_in_unsafe_fn lints.

Fixed every resulting warning (527 -> 0) mechanically per clippy's suggestions:
inline format args, const fns, item ordering, let-else, redundant clones,
map_or, cast_lossless, Eq derives, associated-fn conversions for methods that
never used self, and removing unnecessary Result wrappers whose call sites could
never propagate an error. No runtime behavior changed; cargo fmt applied.

cargo clippy --workspace --all-targets: 0 warnings. All tests pass.

This commit is contained in:

michel

2026-07-19 00:09:17 +02:00

parent b149a8ecf2

commit e72c8a5c07

37 changed files with 482 additions and 433 deletions

									
										soulseek-rs/Cargo.toml
									
		+3
		
												View File
												
				@@ -13,6 +13,9 @@ categories = ["command-line-utilities"]

				name = "soulseek-rs"

				path = "src/main.rs"

				[lints]

				workspace = true

				[dependencies]

				soulseek-rs-lib = { version = "0.3.0", path = "../soulseek-rs-lib" }