fix: clippy cleanups in upload tracking and share plumbing

soulseek-rs-lib/src/client/connection.rs

@@ -46,7 +46,7 @@ impl Client {
         let shared_folder_count = shares.folder_count();
         let shared_file_count = shares.file_count();
         ctx.shares = shares;
-        ctx.shared_directories = self.shared_directories.clone();
+        ctx.shared_directories.clone_from(&self.shared_directories);
 
         let server_actor = ServerActor::new(
             self.address.clone(),

soulseek-rs-lib/src/client/mod.rs

@@ -701,6 +701,7 @@ impl Client {
 
     /// Ask an in-progress upload to `username` of `filename` to stop.
     /// Returns whether a matching in-progress upload was found.
+    #[must_use = "returns whether a matching upload was found"]
     pub fn cancel_upload(&self, username: &str, filename: &str) -> bool {
         self.context.read_safe().is_ok_and(|ctx| {
             let mut found = false;