refactor: resolve all lint findings

- remove 34 trivial restating comments (auto-fix) - replace all 20 production .unwrap() calls with graceful handling: ?-propagation via LockPoisoned, unwrap_or_default on infallible conversions, let _ = on actor-channel sends, and a downloads_sender() helper in the TUI that also dedupes three channel-init blocks - collapse nested if into match guard (clippy::collapsible_match) - split client.rs (2275 lines) into a client/ module: connection, search, downloads, uploads, rooms, operations - split ui/main_tui.rs (2027 lines) into a main_tui/ module: render, input, browse, rooms, downloads, search - extract oversized functions: peer_actor/server_actor handle_message into per-message helpers, main() into init_logging/run_default_tui, download_selector and main_tui render into per-section helpers Mechanical only, zero behavior change. Verified: clippy clean (pedantic+nursery), fmt clean, 143 unit tests + 16 e2e tests against soulfind pass, lint clean.
2026-07-20 10:53:57 +02:00
parent 17864ac9b0
commit 2918b0ce75
35 changed files with 4113 additions and 3983 deletions
@@ -0,0 +1,70 @@
+use super::{
+    Arc, Client, ClientContext, DownloadStatus, RwLock, RwLockExt,
+    collect_failed_tokens, error, thread,
+};
+
+impl Client {
+    /// Consume the upload job for `token` and stream the file to `host:port`
+    /// on a background thread.
+    pub(crate) fn spawn_serve(
+        client_context: &Arc<RwLock<ClientContext>>,
+        own_username: &str,
+        token: u32,
+        host: String,
+        port: u32,
+    ) {
+        let Ok(mut ctx) = client_context.write_safe() else {
+            return;
+        };
+        let Some(job) = ctx.uploads.remove(&token) else {
+            return;
+        };
+        drop(ctx);
+        let own = own_username.to_string();
+        let real_path = job.real_path;
+        thread::spawn(move || {
+            if let Err(e) = crate::peer::upload_peer::serve_file(
+                &host, port, &own, token, &real_path,
+            ) {
+                error!("[client] serve {}: {}", real_path.display(), e);
+            }
+        });
+    }
+
+    pub(crate) fn process_failed_uploads(
+        client_context: Arc<RwLock<ClientContext>>,
+        username: &str,
+        filename: Option<&str>,
+    ) {
+        let failed_tokens = match client_context.read_safe() {
+            Ok(context) => {
+                collect_failed_tokens(&context.downloads, username, filename)
+            }
+            Err(e) => {
+                error!("[client] process_failed_uploads read: {}", e);
+                return;
+            }
+        };
+
+        if failed_tokens.is_empty() {
+            return;
+        }
+
+        match client_context.write_safe() {
+            Ok(mut context) => {
+                for token in failed_tokens {
+                    context.downloads.update_status(
+                        token,
+                        DownloadStatus::Failed(Some(
+                            "The upload failed on the other side".to_string(),
+                        )),
+                    );
+                    context.downloads.remove(token);
+                }
+            }
+            Err(e) => {
+                error!("[client] process_failed_uploads write: {}", e);
+            }
+        }
+    }
+}